Ndev 3414 update solana to v2.0 #579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancientmage
force-pushed
the
NDEV-3414-update-solana-to-v2.0
branch
7 times, most recently
from
1062296 to
20d7f04
Compare
ancientmage
force-pushed
the
NDEV-3414-update-solana-to-v2.0
branch
from
20d7f04 to
5b82c28
Compare
Dapps report |
Solana Requests Statistics
|
s-medvedev
approved these changes
Dec 10, 2024
| cargo build --release && \ | ||
| cargo clippy --release \ | ||
| --config 'patch.crates-io.ethnum.git="https://github.com/neonlabsorg/ethnum.git"'\ | ||
| --config 'patch.crates-io.ethnum.branch="NDEV-3414-u256-in-u64-4-implementation"' && \ |
There was a problem hiding this comment.
Please create PR into neonlabsorg/ethnum.git to merge branch into main
| thiserror = "1.0" | ||
| arrayref = "0.3.8" | ||
| hex = "0.4.3" | ||
| ripemd = "0.1" | ||
| rlp = "0.5" | ||
| static_assertions = "1" | ||
| borsh = "0.10" | ||
| borsh = "1.5.2" | ||
| borsh010 = { version = "0.10.4", package = "borsh" } |
There was a problem hiding this comment.
What is the difference between borsch v1.5.2 and v0.10.4? Why do we need to use both of them?
There was a problem hiding this comment.
There is no difference for us between this two crates. Mpl-token-metadata crate depends on >=0.9, <1.0 borsh. Solana-program depends on both borsh 1.5 and 0.10. So, we need to tell which version of borsh. Because it does not support deserialization from v1.5 trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.